toni/zern
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

typecheck_expr doesnt need to mutate the TypeChecker

Browse Source
This commit is contained in:
Antoni Piasecki
2026-03-18 19:08:10 +01:00
parent 0dbe7560b6
commit 625fc0d811
2 changed files with 3 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
src/codegen_x86_64.rs
View File

@@ -564,7 +564,7 @@ _builtin_environ:
} else { } else {
let var = match env.get_var(&name.lexeme) { let var = match env.get_var(&name.lexeme) {
Some(x) => x, Some(x) => x,
None => unreachable!(), None => unreachable!("this should be caught in the typechecker"),
}; };
emit!( emit!(
&mut self.output, &mut self.output,

4
src/typechecker.rs
View File

@@ -219,7 +219,7 @@ impl<'a> TypeChecker<'a> {
Ok(()) Ok(())
} }
pub fn typecheck_expr(&mut self, env: &mut Env, expr: &Expr) -> Result<Type, ZernError> { pub fn typecheck_expr(&self, env: &mut Env, expr: &Expr) -> Result<Type, ZernError> {
match expr { match expr {
Expr::Binary { left, op, right } => { Expr::Binary { left, op, right } => {
let left_type = self.typecheck_expr(env, left)?; let left_type = self.typecheck_expr(env, left)?;
@@ -370,7 +370,7 @@ impl<'a> TypeChecker<'a> {
} => { } => {
if let Expr::Variable(callee_name) = &**callee { if let Expr::Variable(callee_name) = &**callee {
if self.analyzer.functions.contains_key(&callee_name.lexeme) { if self.analyzer.functions.contains_key(&callee_name.lexeme) {
let fn_type = &self.analyzer.functions[&callee_name.lexeme].clone(); let fn_type = &self.analyzer.functions[&callee_name.lexeme];
// its a function (defined/builtin/extern) // its a function (defined/builtin/extern)
if let Some(params) = fn_type.params.clone() { if let Some(params) = fn_type.params.clone() {
for (i, arg) in args.iter().enumerate() { for (i, arg) in args.iter().enumerate() {